Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bridge-ui): selecting chain was not informing of errors #13712

Merged
merged 46 commits into from
May 13, 2023
Merged

fix(bridge-ui): selecting chain was not informing of errors #13712

merged 46 commits into from
May 13, 2023

Conversation

jscriptcoder
Copy link
Contributor

@jscriptcoder jscriptcoder commented May 5, 2023 •
edited
Loading

  • Reusing code to select the chain
  • Improving the error handing
  • Informing the user when there is a problem switching networks (ChainDropdown was not doing this)
  • Installed debug package. I'd like to be able to see logs in production based on a flag. Debug is a very small package with a nice way to visualise logs, which you can namespace filter

@jscriptcoder jscriptcoder changed the base branch from main to update_abis May 5, 2023 11:40
@codecov
Copy link

codecov bot commented May 5, 2023 •
edited
Loading

Codecov Report

Merging #13712 (c6f7f13) into main (d3d4e69) will increase coverage by 0.37%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #13712      +/-   ##
==========================================
+ Coverage   45.00%   45.37%   +0.37%     
==========================================
  Files         130      132       +2     
  Lines        3520     3544      +24     
  Branches      363      365       +2     
==========================================
+ Hits         1584     1608      +24     
  Misses       1835     1835              
  Partials      101      101
Flag Coverage Δ *Carryforward flag
bridge-ui 96.20% <100.00%> (+0.19%) ⬆️
eventindexer 82.08% <ø> (ø) Carriedforward from 94650cb
protocol 0.00% <ø> (ø) Carriedforward from 94650cb
relayer 62.55% <ø> (ø) Carriedforward from 94650cb
ui 100.00% <ø> (ø) Carriedforward from 94650cb

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/bridge-ui/src/utils/logger.ts 100.00% <100.00%> (ø)
packages/bridge-ui/src/utils/selectChain.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jscriptcoder jscriptcoder self-assigned this May 5, 2023
@jscriptcoder jscriptcoder changed the title fix(bridge-ui): select chain fix(bridge-ui): selecting chain wasn't informing of errors May 5, 2023
@jscriptcoder jscriptcoder changed the title fix(bridge-ui): selecting chain wasn't informing of errors fix(bridge-ui): selecting chain was not informing of errors May 5, 2023
Base automatically changed from update_abis to main May 11, 2023 14:10
@jscriptcoder jscriptcoder marked this pull request as ready for review May 11, 2023 16:14
@jscriptcoder jscriptcoder added this pull request to the merge queue May 13, 2023
Merged via the queue into main with commit 5d29c6d May 13, 2023
@jscriptcoder jscriptcoder deleted the select_chain branch May 13, 2023 17:03
@github-actions github-actions bot mentioned this pull request May 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyberhorsey cyberhorsey cyberhorsey approved these changes

@dantaik dantaik dantaik approved these changes

@dionysuzx dionysuzx Awaiting requested review from dionysuzx

Assignees

@jscriptcoder jscriptcoder

Labels
area.bridge category.bug category.enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jscriptcoder @dantaik @cyberhorsey